fix `included` _super class #520

machty · 2016-10-12T22:34:48Z

This fixes issues with people seeing regeneratorRuntime is not defined when ember-concurrency / ember-maybe-import-regenerator are deeply nested dependent addons.

This new ember app demonstrates the bug and is fixed with this change to ember-paper.

Prior art: ember-cli/ember-cli#3718 (comment)

This fixes issues with people seeing `regeneratorRuntime` is not defined when ember-concurrency / ember-maybe-import-regenerator are deeply nested dependent addons. [This new ember app](https://github.com/v3ss0n/ember-paper-menu-error-concurrency) demonstrates the bug and is fixed with this change to ember-paper. Prior art: ember-cli/ember-cli#3718 (comment)

v3ss0n · 2016-10-13T02:23:03Z

Thanks a lot! @machty that was quick!

miguelcobain · 2016-10-13T10:34:27Z

Thanks, @machty!

v3ss0n · 2016-10-13T11:29:04Z

@miguelcobain i think it should b merged to #395 branch since the ember-power-select cause the bug there.

miguelcobain merged commit 6f9589a into adopted-ember-addons:master Oct 13, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix `included` _super class #520

fix `included` _super class #520

machty commented Oct 12, 2016

v3ss0n commented Oct 13, 2016

miguelcobain commented Oct 13, 2016

v3ss0n commented Oct 13, 2016 •

edited

Loading

fix included _super class #520

fix included _super class #520

Conversation

machty commented Oct 12, 2016

v3ss0n commented Oct 13, 2016

miguelcobain commented Oct 13, 2016

v3ss0n commented Oct 13, 2016 • edited Loading

fix `included` _super class #520

fix `included` _super class #520

v3ss0n commented Oct 13, 2016 •

edited

Loading